-
Couldn't load subscription status.
- Fork 8k
Fix parent hook call with named args #20271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: PHP-8.4
Are you sure you want to change the base?
Conversation
| @@ -0,0 +1,49 @@ | |||
| --TEST-- | |||
| GH-20270: Parent hook call with named arguments | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: Missing --CREDITS--.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically looks fine, not sure if you need to explicitly zero more fields to silence compile warnings on some compilers/platforms. They should be zero'd on their own.
Okay, didn't know about this. Will do. |
|
Took a quick look, for GCC I could see: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wmissing-field-initializers
In other words, this warning doesn't apply here. The same goes for Clang. I couldn't find an equivalent option for MSVC at all. I also found a few existing examples in php-src where not all fields are being set, indicating this is probably not an issue. php-src/sapi/fpm/fpm/fpm_cleanup.c Line 16 in eafbc6b
Line 2625 in eafbc6b
|
|
Thanks for checking, LGTM then! |
Fixes GH-20270